mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Put model state into an Arc #28

Merged
sam merged 2 commits from state-arc into main 2026-03-30 00:56:37 +00:00
Conversation 1 Commits 2 Files Changed 9
+115 -70
sam commented 2026-03-29 20:03:50 +00:00
Owner
Copy Link
Copy Source

Previously the model state was in a static STATE to make it accessible to all the various subsystems. This moves it into an Arc and plumbs the reference around via function arguments. That allows us to do non-static initialization, eg based on user config. I also moved some things into dioxus context.

Previously the model state was in a `static STATE` to make it accessible to all the various subsystems. This moves it into an Arc and plumbs the reference around via function arguments. That allows us to do non-static initialization, eg based on user config. I also moved some things into dioxus context.
sam requested review from restitux 2026-03-29 20:04:05 +00:00
sam added 1 commit 2026-03-29 21:42:27 +00:00
initilize state signals directly
Build Mumble Web 2 / macos_build (push) Successful in 54s
Details
Build Mumble Web 2 / linux_build (push) Successful in 1m18s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m45s
Details
Build Mumble Web 2 / android_build (push) Successful in 4m31s
Details
fa39737301
sam force-pushed state-arc from 66467d37e9 to fa39737301 2026-03-29 21:42:27 +00:00 Compare
restitux approved these changes 2026-03-30 00:40:28 +00:00
restitux left a comment
Owner
Copy Link
Copy Source

lgtm

lgtm
sam merged commit f0ce15000e into main 2026-03-30 00:56:37 +00:00
sam deleted branch state-arc 2026-03-30 00:56:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
restitux
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#28
Delete Branch "state-arc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?