Use <button> instead of <a> without href
It is more semantic to use a `<button>` tag in the place of an `<a>` when there is no other page being linked to. In this circumstance, we're using JavaScript to present a modal to the user on click. This change makes the "Upload" and "Rename" buttons appear in the browser's tab index.
This commit is contained in:
@@ -54,21 +54,21 @@
|
|||||||
|
|
||||||
{{#allow_editing}}
|
{{#allow_editing}}
|
||||||
{{#allow_uploads}}
|
{{#allow_uploads}}
|
||||||
<a
|
<button
|
||||||
class="btn BtnGroup-item btn-sm hide-sm hide-md
|
class="btn BtnGroup-item btn-sm hide-sm hide-md
|
||||||
minibutton-upload-page"
|
minibutton-upload-page"
|
||||||
>
|
>
|
||||||
Upload
|
Upload
|
||||||
</a>
|
</button>
|
||||||
{{/allow_uploads}}
|
{{/allow_uploads}}
|
||||||
|
|
||||||
{{#editable}}
|
{{#editable}}
|
||||||
<a
|
<button
|
||||||
class="btn BtnGroup-item btn-sm hide-sm hide-md
|
class="btn BtnGroup-item btn-sm hide-sm hide-md
|
||||||
minibutton-rename-page"
|
minibutton-rename-page"
|
||||||
>
|
>
|
||||||
Rename
|
Rename
|
||||||
</a>
|
</button>
|
||||||
<a
|
<a
|
||||||
class="btn BtnGroup-item btn-sm hide-sm hide-md"
|
class="btn BtnGroup-item btn-sm hide-sm hide-md"
|
||||||
href="{{edit_path}}/{{escaped_url_path}}"
|
href="{{edit_path}}/{{escaped_url_path}}"
|
||||||
@@ -81,7 +81,6 @@
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
|
|
||||||
{{#allow_editing}}
|
{{#allow_editing}}
|
||||||
{{#editable}}
|
{{#editable}}
|
||||||
<div class="TableObject-item">
|
<div class="TableObject-item">
|
||||||
|
|||||||
Reference in New Issue
Block a user