From a22208a0be06f6a476a5017fec008d5c3b75d978 Mon Sep 17 00:00:00 2001
From: Benjamin Willems <bw@benjaminwil.info>
Date: Sun, 21 Mar 2021 14:21:07 -0700
Subject: [PATCH] Use <button> instead of <a> without `href`

It is more semantic to use a `<button>` tag in the place of an `<a>`
when there is no other page being linked to. In this circumstance, we're
using JavaScript to present a modal to the user on click.

This change makes the "Upload" and "Rename" buttons appear in the
browser's tab index.
---
 lib/gollum/templates/navbar.mustache | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lib/gollum/templates/navbar.mustache b/lib/gollum/templates/navbar.mustache
index 2877caee..d86e8c8c 100644
--- a/lib/gollum/templates/navbar.mustache
+++ b/lib/gollum/templates/navbar.mustache
@@ -54,21 +54,21 @@
 
       {{#allow_editing}}
         {{#allow_uploads}}
-          <a
+          <button
             class="btn BtnGroup-item btn-sm hide-sm hide-md
               minibutton-upload-page"
           >
             Upload
-          </a>
+          </button>
         {{/allow_uploads}}
 
         {{#editable}}
-          <a
+          <button
             class="btn BtnGroup-item btn-sm hide-sm hide-md
               minibutton-rename-page"
           >
             Rename
-          </a>
+          </button>
           <a
             class="btn BtnGroup-item btn-sm hide-sm hide-md"
             href="{{edit_path}}/{{escaped_url_path}}"
@@ -81,7 +81,6 @@
     </div>
   </div>
 
-
   {{#allow_editing}}
     {{#editable}}
       <div class="TableObject-item">