mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

common: resolve ping addresses with async DNS #36

Open
restitux wants to merge 1 commits from login-screen-async-dns-lookup into main
pull from: login-screen-async-dns-lookup
merge into: mumble:main
Conversation 0 Commits 1 Files Changed 1
+3 -4
restitux commented 2026-05-06 00:21:48 +00:00
Owner
Copy Link
Copy Source

Summary: The previous std::net::ToSocketAddrs call blocked the runtime during
DNS lookup. This change allows the server ping status to be resolved
asynchronously.

Test Plan: I tested this alongside some other changes I'm doing and with the change the UI has stopped freezing. I see a ... placeholder value while the ping is being resolved.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Summary: The previous std::net::ToSocketAddrs call blocked the runtime during DNS lookup. This change allows the server ping status to be resolved asynchronously. Test Plan: I tested this alongside some other changes I'm doing and with the change the UI has stopped freezing. I see a `...` placeholder value while the ping is being resolved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
restitux added 1 commit 2026-05-06 00:21:49 +00:00
common: resolve ping addresses with async DNS
Build Mumble Web 2 / macos_build (push) Successful in 1m20s
Details
Build Mumble Web 2 / linux_build (push) Successful in 1m27s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m57s
Details
Build Mumble Web 2 / android_build (push) Successful in 4m40s
Details
25ec34d7e7 
The previous std::net::ToSocketAddrs call blocked the runtime during
DNS lookup. This change allows the server ping status to be resolved
asynchronously.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
restitux requested review from sam 2026-05-06 00:21:49 +00:00
Some checks are pending
Build Mumble Web 2 / macos_build (push) Successful in 1m20s
Details
Build Mumble Web 2 / linux_build (push) Successful in 1m27s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m57s
Details
Build Mumble Web 2 / android_build (push) Successful in 4m40s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin login-screen-async-dns-lookup:login-screen-async-dns-lookup
git checkout login-screen-async-dns-lookup
Sign in to join this conversation.
Reviewers
No Reviewers
sam
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#36
Delete Branch "login-screen-async-dns-lookup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?