mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Quick fixes for S&T #27

Merged
liamwarfield merged 3 commits from quick-fixxes-for-s&t into main 2026-03-29 18:24:16 +00:00
Conversation 2 Commits 3 Files Changed 2
+18 -1
liamwarfield commented 2026-03-29 16:24:08 +00:00
Owner
Copy Link
Copy Source

Some quick QAL changes I banged out this morning. The commit messages describe the individual changes in details.

Changes

  • Min window width on desktop.
  • Removes white flash on desktop startup
  • Removes right click menu on release builds (still exists on debug, and might come back in the future with new features).
Some quick QAL changes I banged out this morning. The commit messages describe the individual changes in details. ## Changes - Min window width on desktop. - Removes white flash on desktop startup - Removes right click menu on release builds (still exists on debug, and might come back in the future with new features).
liamwarfield added 3 commits 2026-03-29 16:24:09 +00:00
Desktop now has minimum width. cd1aed2b9a 
I just played around until I found something that looks right.
Before there'd be really degen behavior if you squished the window
too much.
Remove white flash on desktop d12b9b891b 
I ask claude for some other suggestions for things to add here, and
I agree with 2 of them:

- Remove a white flash by setting a default collor of the window as
  black.
- Explicitly set the maximized state.
Remove right click menu in release builds.
Build Mumble Web 2 / windows_build (push) Successful in 3m21s
Details
Build Mumble Web 2 / macos_build (push) Successful in 3m26s
Details
Build Mumble Web 2 / linux_build (push) Successful in 3m36s
Details
Build Mumble Web 2 / android_build (push) Successful in 8m9s
Details
ee7dc2f310 
This makes it so that release builds don't let the right click menu
popup on release builds. This is still allowed on debug builds so that
things like "Inspect Element" are easy to use there.
liamwarfield reviewed 2026-03-29 16:25:27 +00:00
gui/assets/main.scss
@@ -16,6 +16,7 @@ body {
}
#main {
visibility: visible;
liamwarfield commented 2026-03-29 16:25:27 +00:00
Author
Owner
Copy Link
Copy Source

Part of the way I got around the flashing was setting #main to visibility: hidden on startup. This toggles it back when the css gets loaded.

Part of the way I got around the flashing was setting #main to `visibility: hidden` on startup. This toggles it back when the css gets loaded.
restitux changed title from quick-fixxes-for-s&t to Quick fixes for S&T 2026-03-29 18:06:02 +00:00
restitux approved these changes 2026-03-29 18:06:09 +00:00
restitux left a comment
Owner
Copy Link
Copy Source

lgtm

lgtm
liamwarfield merged commit 7337b3e49b into main 2026-03-29 18:24:16 +00:00
liamwarfield deleted branch quick-fixxes-for-s&t 2026-03-29 18:24:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
liamwarfield
restitux
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#27
Delete Branch "quick-fixxes-for-s&t"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?