mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Persistant Desktop settings #11

Merged
samuel127849 merged 3 commits from swarfield/desktop-settings into main 2026-01-10 23:26:22 +00:00
Conversation 3 Commits 3 Files Changed 6
+86 -4
samuel127849 commented 2026-01-10 22:54:03 +00:00
Owner
Copy Link
Copy Source

This pull request implements persistent settings for the desktop client! I used the etcetera library to automatically create config paths that should work on all major os'es. For example, on linux ~/.config/mumble-web2/config.json is used

This pull request implements persistent settings for the desktop client! I used the `etcetera` library to automatically create config paths that should work on all major os'es. For example, on linux `~/.config/mumble-web2/config.json` is used
samuel127849 added 2 commits 2026-01-10 22:54:04 +00:00
Add configuration for rust analyzer for vscode.
Build Mumble Web 2 / linux_build (push) Has been cancelled
Details
Build Mumble Web 2 / windows_build (push) Has been cancelled
Details
86e4753fbc
Added persistant settings on desktop
Build Mumble Web 2 / linux_build (push) Successful in 1m24s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m17s
Details
a7c307959c
samuel127849 requested review from restitux 2026-01-10 22:54:04 +00:00
samuel127849 requested review from sam 2026-01-10 22:54:04 +00:00
samuel127849 commented 2026-01-10 22:54:42 +00:00
Author
Owner
Copy Link
Copy Source

Also added vscode settings for rust analyzer.

Also added vscode settings for rust analyzer.
sam requested changes 2026-01-10 23:04:33 +00:00
Dismissed
gui/src/imp/desktop.rs
@@ -323,3 +362,4 @@
}
pub async fn load_config() -> color_eyre::Result<ClientConfig> {
let config = load_config_map();
sam commented 2026-01-10 23:04:29 +00:00
Owner
Copy Link
Copy Source

Load config should not change, because this is (confusingly) the server->client config, not really the user's own config. TBH we should rename it to "server_params" or something, but probably not in this PR.

Anyway, we should instead plumb the remembered last-used server address to the initial value of address_input of LoginView. That is, use it to pre-fill the field.

Load config should not change, because this is (confusingly) the server->client config, not really the user's own config. TBH we should rename it to "server_params" or something, but probably not in this PR. Anyway, we should instead plumb the remembered last-used server address to the initial value of address_input of LoginView. That is, use it to pre-fill the field.
samuel127849 force-pushed swarfield/desktop-settings from 6702c56f6c to f2474591cb 2026-01-10 23:20:41 +00:00 Compare
samuel127849 requested review from sam 2026-01-10 23:21:44 +00:00
sam approved these changes 2026-01-10 23:21:49 +00:00
samuel127849 merged commit 4abb130a77 into main 2026-01-10 23:26:22 +00:00
samuel127849 deleted branch swarfield/desktop-settings 2026-01-10 23:26:22 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
restitux
sam
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#11
Delete Branch "swarfield/desktop-settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?