Put model state into an Arc (#28)

Previously the model state was in a `static STATE` to make it accessible to all the various subsystems. This moves it into an Arc and plumbs the reference around via function arguments. That allows us to do non-static initialization, eg based on user config. I also moved some things into dioxus context.

Co-authored-by: Sam Sartor <me@samsartor.com>
Co-committed-by: Sam Sartor <me@samsartor.com>

gui/src/app.rs

@@ -4,13 +4,18 @@ use dioxus::prelude::*;
 use mime_guess::Mime;
 use mumble_web2_common::{ProxyOverrides, ServerStatus};
 use ordermap::OrderSet;
-use std::collections::{HashMap, HashSet};
+use std::{
+    collections::{HashMap, HashSet},
+    fmt,
+    sync::Arc,
+};
 
 use crate::imp::{ConfigSystem, ConfigSystemInterface as _, Platform, PlatformInterface as _};
 
 pub type ChannelId = u32;
 pub type UserId = u32;
 
+#[derive(Debug)]
 pub enum ConnectionState {
     Disconnected,
     Connecting,
@@ -54,7 +59,7 @@ pub enum Command {
 use Command::*;
 use ConnectionState::*;
 
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct UserState {
     pub name: String,
     pub channel: ChannelId,
@@ -79,13 +84,14 @@ impl UserState {
     }
 }
 
+#[derive(Debug)]
 pub struct Chat {
     pub raw: String,
     pub dangerous_html: String,
     pub sender: Option<UserId>,
 }
 
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct ChannelState {
     pub name: String,
     pub children: OrderSet<ChannelId>,
@@ -111,7 +117,7 @@ impl ChannelState {
     }
 }
 
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct ChannelsState {
     pub channels: HashMap<ChannelId, ChannelState>,
 }
@@ -198,7 +204,7 @@ impl ChannelsState {
     }
 }
 
-#[derive(Default)]
+#[derive(Default, Debug)]
 pub struct ServerState {
     pub channels_state: ChannelsState,
     pub users: HashMap<UserId, UserState>,
@@ -213,14 +219,20 @@ impl ServerState {
 }
 
 pub struct State {
-    pub status: GlobalSignal<ConnectionState>,
-    pub server: GlobalSignal<ServerState>,
+    pub status: Signal<ConnectionState>,
+    pub server: Signal<ServerState>,
 }
 
-pub static STATE: State = State {
-    status: Signal::global(|| Disconnected),
-    server: Signal::global(|| Default::default()),
-};
+impl fmt::Debug for State {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.debug_struct("State")
+            .field("status", &self.status.read())
+            .field("server", &self.server.read())
+            .finish()
+    }
+}
+
+pub type SharedState = Arc<State>;
 
 #[derive(Clone, Copy, PartialEq, Eq)]
 pub enum UserIcon {
@@ -267,7 +279,8 @@ pub fn UserPill(name: String, icon: UserIcon, isself: bool) -> Element {
 
 #[component]
 pub fn User(id: UserId) -> Element {
-    let server = STATE.server.read();
+    let state = use_context::<SharedState>();
+    let server = state.server.read();
     match server.users.get(&id) {
         Some(state) => rsx!(UserPill {
             name: state.name.clone(),
@@ -285,7 +298,8 @@ pub fn User(id: UserId) -> Element {
 #[component]
 pub fn Channel(id: ChannelId) -> Element {
     let net: Coroutine<Command> = use_coroutine_handle();
-    let server = STATE.server.read();
+    let state = use_context::<SharedState>();
+    let server = state.server.read();
     let user = server.session.unwrap();
     let Some(state) = server.channels_state.channels.get(&id) else {
         return rsx!("missing channel {id}");
@@ -354,7 +368,8 @@ pub fn Channel(id: ChannelId) -> Element {
 
 #[cfg(any(feature = "desktop", feature = "web"))]
 pub fn pick_and_send_file(net: &Coroutine<Command>) {
-    let channels = if let Some(user) = STATE.server.read().this_user() {
+    let state = use_context::<SharedState>();
+    let channels = if let Some(user) = state.server.read().this_user() {
         vec![user.channel]
     } else {
         return;
@@ -380,11 +395,14 @@ pub fn pick_and_send_file(net: &Coroutine<Command>) {}
 #[component]
 pub fn ChatView() -> Element {
     let net: Coroutine<Command> = use_coroutine_handle();
-    let server = STATE.server.read();
+    let state = use_context::<SharedState>();
+    let server = state.server.read();
     let mut draft = use_signal(|| "".to_string());
 
     let mut do_send = move || {
-        if let Some(user) = STATE.server.read().this_user() {
+        let state = use_context::<SharedState>();
+        let server = state.server.read();
+        if let Some(user) = server.this_user() {
             net.send(SendChat {
                 markdown: draft.write().split_off(0),
                 channels: vec![user.channel],
@@ -456,8 +474,9 @@ pub fn ChatView() -> Element {
 #[component]
 pub fn ControlView(overrides: Resource<ProxyOverrides>) -> Element {
     let net: Coroutine<Command> = use_coroutine_handle();
-    let status = &STATE.status;
-    let server = STATE.server.read();
+    let state = use_context::<SharedState>();
+    let status = &state.status;
+    let server = state.server.read();
     let Some(&UserState {
         deaf,
         self_deaf,
@@ -645,9 +664,10 @@ pub fn ControlView(overrides: Resource<ProxyOverrides>) -> Element {
 }
 
 #[component]
-pub fn ServerView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem) -> Element {
+pub fn ServerView(overrides: Resource<ProxyOverrides>) -> Element {
     let net: Coroutine<Command> = use_coroutine_handle();
-    let server = STATE.server.read();
+    let state = use_context::<SharedState>();
+    let server = state.server.read();
     let Some(&UserState {
         deaf,
         self_deaf,
@@ -683,7 +703,8 @@ pub fn ServerView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem
 }
 
 #[component]
-pub fn LoginView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem) -> Element {
+pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
+    let user_config = use_context::<ConfigSystem>();
     let net: Coroutine<Command> = use_coroutine_handle();
 
     let last_status = use_signal(|| None::<color_eyre::Result<ServerStatus>>);
@@ -706,8 +727,11 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem)
         }
     });
 
-    let previous_username = user_config.config_get::<String>("username");
-    let mut username = use_signal(|| previous_username.unwrap_or(String::new()));
+    let mut username = use_signal(|| {
+        user_config
+            .config_get::<String>("username")
+            .unwrap_or(String::new())
+    });
 
     let do_connect = move |_| {
         let _ = user_config.config_set::<String>("username", &username.read());
@@ -720,7 +744,8 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem)
             config: overrides.read().clone().unwrap_or_default(),
         })
     };
-    let status = &STATE.status;
+    let state = use_context::<SharedState>();
+    let status = &state.status;
     let bottom = match &*status.read() {
         Disconnected => rsx! {
             button {
@@ -854,10 +879,26 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>, user_config: ConfigSystem)
     //    )
 }
 
+#[component]
 pub fn app() -> Element {
     static STYLE: Asset = asset!("/assets/main.scss");
 
-    use_coroutine(|rx: UnboundedReceiver<Command>| super::network_entrypoint(rx));
+    use_effect(|| {
+        Platform::request_permissions();
+    });
+
+    use_root_context(|| ConfigSystem::new().unwrap());
+    let state = use_root_context(|| {
+        SharedState::new(State {
+            status: Signal::new(Disconnected),
+            server: Signal::new(Default::default()),
+        })
+    });
+
+    let network_state = state.clone();
+    use_coroutine(move |rx: UnboundedReceiver<Command>| {
+        super::network_entrypoint(rx, network_state.clone())
+    });
     let overrides = use_resource(|| async move {
         match Platform::load_proxy_overrides().await {
             Ok(overrides) => overrides,
@@ -865,18 +906,14 @@ pub fn app() -> Element {
         }
     });
 
-    let user_config = ConfigSystem::new().unwrap();
-
-    Platform::request_permissions();
-
     rsx!(
         document::Link{ rel: "stylesheet", href: "https://fonts.googleapis.com/css2?family=Nunito:ital,wght@0,200..1000;1,200..1000&display=swap" }
         document::Link{ rel: "stylesheet", href: "https://fonts.googleapis.com/css2?family=Material+Symbols+Outlined:opsz,wght,FILL,GRAD@20..48,100..700,0..1,-50..200" }
         document::Link{ rel: "stylesheet", href: STYLE }
 
-        match *STATE.status.read() {
-            Connected => rsx!(ServerView { overrides, user_config }),
-            _ => rsx!(LoginView { overrides, user_config }),
+        match *state.status.read() {
+            Connected => rsx!(ServerView { overrides }),
+            _ => rsx!(LoginView { overrides }),
         }
     )
 }