Fix usericons (#1408)

* Fix and refactor user icons, add Basic tests
* Remove identicon_canvas, use identicon.js
* Use octicon by default
This commit is contained in:
Dawa Ometto
2019-09-01 21:45:55 +02:00
committed by GitHub
parent 569eac3a06
commit d1b1375629
23 changed files with 292 additions and 620 deletions
+17 -2
View File
@@ -12,12 +12,13 @@ context "Precious::Views::LatestChanges" do
setup do
@path = cloned_testpath("examples/lotr.git")
@wiki = Gollum::Wiki.new(@path)
@url = '/gollum/latest_changes'
Precious::App.set(:gollum_path, @path)
Precious::App.set(:wiki_options, {:pagination_count => 10})
end
test "displays_latest_changes" do
get('/gollum/latest_changes')
get(@url)
body = last_response.body
assert body.include?("Charles Pence</span>"), "/latest_changes should include Author Charles Pence"
@@ -27,6 +28,20 @@ context "Precious::Views::LatestChanges" do
assert body.include?('<a href="Hobbit.md/874f597a5659b4c3b153674ea04e406ff393975e">Hobbit.md</a>'), "/latest_changes should include links to modified pages in #{body}"
end
test 'gravatar' do
Precious::App.set(:wiki_options, {:user_icons => 'gravatar'})
get @url
assert last_response.body.include?('<img src="https://secure.gravatar.com/'), "gravatar icon missing from #{@url}"
Precious::App.set(:wiki_options, {:user_icons => 'none'})
end
test 'identicon' do
Precious::App.set(:wiki_options, {:user_icons => 'identicon'})
get @url
assert last_response.body.include?('class="identicon" data-identicon="'), "identicon icon missing from #{@url}"
Precious::App.set(:wiki_options, {:user_icons => 'none'})
end
test "extract destination file name in case of path renaming" do
view = Precious::Views::LatestChanges.new
assert_equal "newname.md", view.extract_renamed_path_destination("oldname.md => newname.md")
@@ -36,4 +51,4 @@ context "Precious::Views::LatestChanges" do
teardown do
FileUtils.rm_rf(@path)
end
end
end