GitAccess#ref_to_sha should never return a blank string

This commit is contained in:
risk
2011-07-14 14:30:23 -07:00
parent 4abc32f1ec
commit bb06b566cd
+6 -2
View File
@@ -28,13 +28,17 @@ module Gollum
# #
# ref - a String Git reference (ex: "master") # ref - a String Git reference (ex: "master")
# #
# Returns a String. # Returns a String, or nil if the ref isn't found.
def ref_to_sha(ref) def ref_to_sha(ref)
ref = ref.to_s
return if ref.empty?
sha =
if sha?(ref) if sha?(ref)
ref ref
else else
get_cache(:ref, ref) { ref_to_sha!(ref) } get_cache(:ref, ref) { ref_to_sha!(ref) }
end end.to_s
sha.empty? ? nil : sha
end end
# Public: Gets a recursive list of Git blobs for the whole tree at the # Public: Gets a recursive list of Git blobs for the whole tree at the