From 3060a3576f2a671f71868bcd5c8d6cd8fc7987dd Mon Sep 17 00:00:00 2001
From: Dan Howe <dan.howe.mail@gmail.com>
Date: Wed, 19 Sep 2018 22:48:09 +1000
Subject: [PATCH] Handle non-image uploads correctly

---
 .../public/gollum/javascript/editor/gollum.editor.js   | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/gollum/public/gollum/javascript/editor/gollum.editor.js b/lib/gollum/public/gollum/javascript/editor/gollum.editor.js
index 3bb44a7a..3b9d86f9 100755
--- a/lib/gollum/public/gollum/javascript/editor/gollum.editor.js
+++ b/lib/gollum/public/gollum/javascript/editor/gollum.editor.js
@@ -217,7 +217,15 @@
             type: 'POST',
             success: function(){
               $editorBody.removeClass('uploading');
-              var text = '[[/' + uploadDest + '/' + file.name + ']]';
+              var ext = file.name.split('.').pop().toLowerCase()
+              var image_ext = ['jpg', 'jpeg', 'tif', 'tiff', 'png', 'gif', 'svg', 'bmp']
+              // Link directly to image files
+              if ((image_ext.indexOf(ext) > -1)) {
+                var text = '[[/' + uploadDest + '/' + file.name + ']]';
+              } else {
+                // Add file name to tag for non-image files, to avoid broken image thumbnail
+                var text = '[[' + file.name + '|/' + uploadDest + '/' + file.name + ']]';
+              }
               window.ace_editor.insert(text);
             },
             error: function(r, textStatus) {