Merge pull request #890 from repotag/ignore_footer_header_sidebar_if_empty

Do not render footers, headers and sidebars if (after formatting) they are empty. Resolves #398 .

lib/gollum/views/page.rb

@@ -56,9 +56,13 @@ module Precious
       end
 
       def has_header
-        @header = (@page.header || false) if @header.nil?
+        if @header
+          return false if @header.formatted_data.strip.empty?
+        else
+          @header = (@page.header || false)
           !!@header
         end
+      end
 
       def header_content
         has_header && @header.formatted_data
@@ -69,9 +73,13 @@ module Precious
       end
 
       def has_footer
-        @footer = (@page.footer || false) if @footer.nil?
+        if @footer
+          return false if @footer.formatted_data.strip.empty?
+        else
+          @footer = (@page.footer || false)
           !!@footer
         end
+      end
 
       def footer_content
         has_footer && @footer.formatted_data
@@ -86,9 +94,13 @@ module Precious
       end
 
       def has_sidebar
-        @sidebar = (@page.sidebar || false) if @sidebar.nil?
+        if @sidebar
+          return false if @sidebar.formatted_data.strip.empty?
+        else
+          @sidebar = (@page.sidebar || false)
           !!@sidebar
         end
+      end
 
       def sidebar_content
         has_sidebar && @sidebar.formatted_data