Merge pull request #890 from repotag/ignore_footer_header_sidebar_if_empty

Do not render footers, headers and sidebars if (after formatting) they are empty. Resolves #398 .

lib/gollum/views/page.rb

@@ -56,8 +56,12 @@ module Precious
       end
 
       def has_header
-        @header = (@page.header || false) if @header.nil?
+        if @header
-        !!@header
+          return false if @header.formatted_data.strip.empty?
+        else
+          @header = (@page.header || false)
+          !!@header
+        end
       end
 
       def header_content
@@ -69,8 +73,12 @@ module Precious
       end
 
       def has_footer
-        @footer = (@page.footer || false) if @footer.nil?
+        if @footer
-        !!@footer
+          return false if @footer.formatted_data.strip.empty?
+        else
+          @footer = (@page.footer || false)
+          !!@footer
+        end
       end
 
       def footer_content
@@ -86,8 +94,12 @@ module Precious
       end
 
       def has_sidebar
-        @sidebar = (@page.sidebar || false) if @sidebar.nil?
+        if @sidebar
-        !!@sidebar
+          return false if @sidebar.formatted_data.strip.empty?
+        else
+          @sidebar = (@page.sidebar || false)
+          !!@sidebar
+        end
       end
 
       def sidebar_content