-
the ohea admin
[m]: @restitux:ohea.xyz
- Joined on
2022-09-15
Block a user
Add a default noise floor.
lgtm overall, though I left two comments about the code structure that I think would make this easier to reason about and slightly easier to maintain
Add a default noise floor.
This logic is duplicated in both Transmitting and Terminator? Could we possibly pull this match statement up a level out of imp and have encode_and_send be the platform specific code boundary?
Add a default noise floor.
nit: I'm not a huge fan of this encode_and_send closure logic. Could we just define this as a separate function and push down the match state match statement into the function?