mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Move mumble UDP ping into common crate #33

Merged
sam merged 1 commits from ping-on-desktop into main 2026-05-05 04:37:20 +00:00
Conversation 1 Commits 1 Files Changed 14
+112 -231
sam commented 2026-05-05 04:27:29 +00:00
Owner
Copy Link
Copy Source

The desktop GUI doesn't go through the proxy to reach the Mumble server,
so its login screen needs to ping directly. Rather than duplicate the
ping logic, move it into the common crate behind an optional
networking feature (so common stays lightweight when the feature
isn't requested).

  • common: add ping_server(address, port) behind networking feature
  • proxy: replace the inline UdpSocket ping + ping.rs codec with a call
    to common::ping_server; drop the rand dep
  • client: PlatformInterface::get_status now takes an address; desktop
    and mobile call common::ping_server directly, web still uses the
    proxy's /status endpoint
  • gui: thread the address from the login input through get_status, so
    it re-pings when the user edits the address

Assisted-by: claude-opus-4-7

The desktop GUI doesn't go through the proxy to reach the Mumble server, so its login screen needs to ping directly. Rather than duplicate the ping logic, move it into the common crate behind an optional `networking` feature (so common stays lightweight when the feature isn't requested). - common: add `ping_server(address, port)` behind `networking` feature - proxy: replace the inline UdpSocket ping + ping.rs codec with a call to common::ping_server; drop the rand dep - client: PlatformInterface::get_status now takes an address; desktop and mobile call common::ping_server directly, web still uses the proxy's /status endpoint - gui: thread the address from the login input through get_status, so it re-pings when the user edits the address Assisted-by: claude-opus-4-7
sam added 1 commit 2026-05-05 04:27:29 +00:00
Move mumble UDP ping into common crate
Build Mumble Web 2 / macos_build (push) Failing after 2s
Details
Build Mumble Web 2 / linux_build (push) Failing after 0s
Details
Build Mumble Web 2 / android_build (push) Failing after 2s
Details
Build Mumble Web 2 / windows_build (push) Failing after 11s
Details
a560bfd420 
The desktop GUI doesn't go through the proxy to reach the Mumble server,
so its login screen needs to ping directly. Rather than duplicate the
ping logic, move it into the common crate behind an optional
`networking` feature (so common stays lightweight when the feature
isn't requested).

- common: add `ping_server(address, port)` behind `networking` feature
- proxy: replace the inline UdpSocket ping + ping.rs codec with a call
  to common::ping_server; drop the rand dep
- client: PlatformInterface::get_status now takes an address; desktop
  and mobile call common::ping_server directly, web still uses the
  proxy's /status endpoint
- gui: thread the address from the login input through get_status, so
  it re-pings when the user edits the address

Assisted-by: claude-opus-4-7
sam requested review from restitux 2026-05-05 04:28:03 +00:00
restitux approved these changes 2026-05-05 04:34:20 +00:00
sam merged commit e72bb6d4c4 into main 2026-05-05 04:37:20 +00:00
sam deleted branch ping-on-desktop 2026-05-05 04:37:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
restitux
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#33
Delete Branch "ping-on-desktop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?