mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Persist denoise setting #24

Merged
sam merged 1 commits from persist-denoise into main 2026-03-30 01:30:14 +00:00
Conversation 2 Commits 1 Files Changed 2
+36 -19
sam commented 2026-03-01 01:16:40 +00:00
Owner
Copy Link
Copy Source

This creates creates generic load_config/store_config functions for persistant settings, and then uses them to persist the denoise setting. Those could be two separate PRs if we want.

Note this is currently on top of #23, creating some extra diff.

This creates creates generic load_config/store_config functions for persistant settings, and then uses them to persist the denoise setting. Those could be two separate PRs if we want. Note this is currently on top of #23, creating some extra diff.
sam changed title from persist-denoise to Persist denoise setting 2026-03-01 01:16:54 +00:00
sam added 1 commit 2026-03-30 00:57:05 +00:00
persist denoise setting
Build Mumble Web 2 / macos_build (push) Successful in 57s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m44s
Details
Build Mumble Web 2 / linux_build (push) Successful in 1m14s
Details
Build Mumble Web 2 / android_build (push) Successful in 4m24s
Details
d3b1414025
sam force-pushed persist-denoise from 92c4788f51 to d3b1414025 2026-03-30 00:57:05 +00:00 Compare
sam requested review from restitux 2026-03-30 00:58:39 +00:00
restitux approved these changes 2026-03-30 01:28:38 +00:00
restitux left a comment
Owner
Copy Link
Copy Source

lgtm

lgtm
sam commented 2026-03-30 01:30:03 +00:00
Author
Owner
Copy Link
Copy Source

Puts the denoise bool into an AudioSettings struct in the model state, and persists changes to user state.

Puts the denoise bool into an AudioSettings struct in the model state, and persists changes to user state.
sam merged commit 7f35a216cd into main 2026-03-30 01:30:14 +00:00
sam deleted branch persist-denoise 2026-03-30 01:30:14 +00:00
sam referenced this issue from a commit 2026-03-30 01:30:15 +00:00
Persist denoise setting (#24)
Sign in to join this conversation.
Reviewers
No Reviewers
restitux
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#24
Delete Branch "persist-denoise"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?