mumble/mumble-web2
6
0
Fork 0
Code Issues Pull Requests 5 Actions Packages Projects Releases Wiki Activity

gui: improve channel selection behavior #21

Merged
restitux merged 2 commits from improve-channel-selection-behavior into main 2026-01-28 06:03:23 +00:00
Conversation 2 Commits 2 Files Changed 2
+78 -9
restitux commented 2026-01-25 20:27:54 +00:00
Owner
Copy Link
Copy Source

Summary

This change improves the channel selection behavior to be more similar to the official client and generally more usable. It's currently mildly broken due to the details element grabbing click events from the whole row and the row text being selectable. This change also makes it more obvious that the channel title can be clicked. I'm not sure how this works on mobile, so we might need to make more changes there in the future to work better with touchscreens.

Changes

  • Channels can only be expanded or collapsed by clicking on the adjacent arrow
  • Expand/collapse arrows are only displayed on channels with children or users
  • Channel can only be joined by double clicking to the right of the collapse/expand arrow
  • The channel title background (and the empty space to the right) display a highlight when the user hovers over them.
  • All text inside the channel view is no longer selectable.

Testing

I tested on the desktop client. I didn't test on mobile but I'll give it a shot after I merge and maybe come back with another PR to make this behavior more intuitive over there.

# Summary This change improves the channel selection behavior to be more similar to the official client and generally more usable. It's currently mildly broken due to the details element grabbing click events from the whole row and the row text being selectable. This change also makes it more obvious that the channel title can be clicked. I'm not sure how this works on mobile, so we might need to make more changes there in the future to work better with touchscreens. # Changes - Channels can only be expanded or collapsed by clicking on the adjacent arrow - Expand/collapse arrows are only displayed on channels with children or users - Channel can only be joined by double clicking to the right of the collapse/expand arrow - The channel title background (and the empty space to the right) display a highlight when the user hovers over them. - All text inside the channel view is no longer selectable. # Testing I tested on the desktop client. I didn't test on mobile but I'll give it a shot after I merge and maybe come back with another PR to make this behavior more intuitive over there.
restitux added 2 commits 2026-01-25 20:27:55 +00:00
channel selection works a lot better 37dc3ffa47
add background hover color change
Build Mumble Web 2 / linux_build (push) Successful in 1m39s
Details
Build Mumble Web 2 / windows_build (push) Successful in 2m33s
Details
Build Mumble Web 2 / android_build (push) Successful in 6m4s
Details
bd4620139f
restitux changed title from gui: Improve channel selection behavior to gui: improve channel selection behavior 2026-01-25 20:28:03 +00:00
liamwarfield reviewed 2026-01-27 02:27:01 +00:00
gui/assets/main.scss
@@ -86,0 +101,4 @@
visibility: hidden;
}
/* The whole right side of the row is the dblclick target */
liamwarfield commented 2026-01-27 02:27:01 +00:00
Owner
Copy Link
Copy Source

We might want to make this a single click on mobile. In my experience double clicks (especially if there are a lot of nearby elements) can be awkward on mobile.

We might want to make this a single click on mobile. In my experience double clicks (especially if there are a lot of nearby elements) can be awkward on mobile.
restitux commented 2026-01-28 06:03:05 +00:00
Author
Owner
Copy Link
Copy Source

I agree that double click is bad ux on mobile. Maybe we can just have a button here that appears only on mobile? Honestly it might prove to be nice to have on desktop as well.

I agree that double click is bad ux on mobile. Maybe we can just have a button here that appears only on mobile? Honestly it might prove to be nice to have on desktop as well.
restitux marked this conversation as resolved
liamwarfield commented 2026-01-27 02:27:07 +00:00
Owner
Copy Link
Copy Source

I can confirm that it behaves as I expect. Overall it LGTM, but none of this is my specialty ¯_(ツ)_/¯

I can confirm that it behaves as I expect. Overall it LGTM, but none of this is my specialty ¯\_(ツ)_/¯
restitux merged commit 2fcb853c30 into main 2026-01-28 06:03:23 +00:00
restitux deleted branch improve-channel-selection-behavior 2026-01-28 06:03:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
liamwarfield
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
liamwarfield (Liam Warfield) mumble-bot ohea-bot restitux (restitux) sam (Sam Sartor) samuel127849 (Samuel Warfield)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mumble/mumble-web2#21
Delete Branch "improve-channel-selection-behavior"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?