1 Commits

Author SHA1 Message Date
sam 25730858f7 gui: new login screen
Build Mumble Web 2 / macos_build (push) Successful in 1m6s
Build Mumble Web 2 / linux_build (push) Successful in 1m26s
Build Mumble Web 2 / windows_build (push) Successful in 3m7s
Build Mumble Web 2 / android_build (push) Successful in 4m34s
2026-05-04 23:04:03 -06:00
12 changed files with 209 additions and 401 deletions
+1 -7
View File
@@ -21,16 +21,10 @@ pub struct AudioSettings {
pub denoise: bool, pub denoise: bool,
} }
#[derive(Debug, Clone)]
pub enum ConnectTarget {
Direct { host: String, port: u16 },
Proxy(String),
}
#[derive(Debug)] #[derive(Debug)]
pub enum Command { pub enum Command {
Connect { Connect {
target: ConnectTarget, address: String,
username: String, username: String,
config: ProxyOverrides, config: ProxyOverrides,
}, },
+6 -12
View File
@@ -1,5 +1,5 @@
use crate::app::{Command, ConnectTarget, SharedState}; use crate::app::{Command, SharedState};
use color_eyre::eyre::{bail, Error}; use color_eyre::eyre::Error;
use futures_channel::mpsc::UnboundedReceiver; use futures_channel::mpsc::UnboundedReceiver;
use mumble_protocol::control::ClientControlCodec; use mumble_protocol::control::ClientControlCodec;
use std::net::ToSocketAddrs; use std::net::ToSocketAddrs;
@@ -70,7 +70,7 @@ impl ServerCertVerifier for NoCertificateVerification {
#[instrument] #[instrument]
pub async fn network_connect( pub async fn network_connect(
target: ConnectTarget, address: String,
username: String, username: String,
event_rx: &mut UnboundedReceiver<Command>, event_rx: &mut UnboundedReceiver<Command>,
overrides: &ProxyOverrides, overrides: &ProxyOverrides,
@@ -78,13 +78,6 @@ pub async fn network_connect(
) -> Result<(), Error> { ) -> Result<(), Error> {
info!("connecting"); info!("connecting");
let (host, port) = match target {
ConnectTarget::Direct { host, port } => (host, port),
ConnectTarget::Proxy(_) => {
bail!("desktop/mobile platform requires a direct host:port, not a proxy URL")
}
};
let config = ClientConfig::builder() let config = ClientConfig::builder()
.dangerous() .dangerous()
.with_custom_certificate_verifier(Arc::new(NoCertificateVerification)) .with_custom_certificate_verifier(Arc::new(NoCertificateVerification))
@@ -92,14 +85,15 @@ pub async fn network_connect(
let connector = TlsConnector::from(Arc::new(config)); let connector = TlsConnector::from(Arc::new(config));
let addr = (&*host, port) let addr = format!("{}:{}", address, 64738)
.to_socket_addrs()? .to_socket_addrs()?
.next() .next()
.unwrap(); .unwrap();
let server_tcp = TcpStream::connect(addr).await?; let server_tcp = TcpStream::connect(addr).await?;
let server_stream = connector let server_stream = connector
.connect(host.try_into()?, server_tcp) //.connect("127.0.0.1".try_into()?, server_tcp)
.connect(address.try_into()?, server_tcp)
.await?; .await?;
let (read_server, write_server) = tokio::io::split(server_stream); let (read_server, write_server) = tokio::io::split(server_stream);
+3 -3
View File
@@ -1,4 +1,4 @@
use crate::app::{Command, ConnectTarget, SharedState}; use crate::app::{Command, SharedState};
use color_eyre::eyre::Error; use color_eyre::eyre::Error;
use futures_channel::mpsc::UnboundedReceiver; use futures_channel::mpsc::UnboundedReceiver;
use mumble_web2_common::{ProxyOverrides, ServerStatus}; use mumble_web2_common::{ProxyOverrides, ServerStatus};
@@ -24,13 +24,13 @@ impl super::PlatformInterface for DesktopPlatform {
} }
async fn network_connect( async fn network_connect(
target: ConnectTarget, address: String,
username: String, username: String,
event_rx: &mut UnboundedReceiver<Command>, event_rx: &mut UnboundedReceiver<Command>,
overrides: &ProxyOverrides, overrides: &ProxyOverrides,
state: SharedState, state: SharedState,
) -> Result<(), Error> { ) -> Result<(), Error> {
super::connect::network_connect(target, username, event_rx, overrides, state).await super::connect::network_connect(address, username, event_rx, overrides, state).await
} }
async fn get_status( async fn get_status(
+3 -3
View File
@@ -1,4 +1,4 @@
use crate::app::{Command, ConnectTarget, SharedState}; use crate::app::{Command, SharedState};
use color_eyre::eyre::Error; use color_eyre::eyre::Error;
use futures_channel::mpsc::UnboundedReceiver; use futures_channel::mpsc::UnboundedReceiver;
use mumble_web2_common::{ProxyOverrides, ServerStatus}; use mumble_web2_common::{ProxyOverrides, ServerStatus};
@@ -20,13 +20,13 @@ impl super::PlatformInterface for MobilePlatform {
} }
async fn network_connect( async fn network_connect(
target: ConnectTarget, address: String,
username: String, username: String,
event_rx: &mut UnboundedReceiver<Command>, event_rx: &mut UnboundedReceiver<Command>,
overrides: &ProxyOverrides, overrides: &ProxyOverrides,
state: SharedState, state: SharedState,
) -> Result<(), Error> { ) -> Result<(), Error> {
super::connect::network_connect(target, username, event_rx, overrides, state).await super::connect::network_connect(address, username, event_rx, overrides, state).await
} }
async fn get_status( async fn get_status(
+2 -2
View File
@@ -4,7 +4,7 @@
//! The traits make the platform boundary explicit and provide compile-time verification. //! The traits make the platform boundary explicit and provide compile-time verification.
#![allow(async_fn_in_trait)] #![allow(async_fn_in_trait)]
use crate::app::{Command, ConnectTarget, SharedState}; use crate::app::{Command, SharedState};
use crate::effects::AudioProcessor; use crate::effects::AudioProcessor;
use color_eyre::eyre::Error; use color_eyre::eyre::Error;
use futures_channel::mpsc::UnboundedReceiver; use futures_channel::mpsc::UnboundedReceiver;
@@ -79,7 +79,7 @@ pub trait PlatformInterface {
/// Establish a connection to the Mumble server and run the network loop. /// Establish a connection to the Mumble server and run the network loop.
fn network_connect( fn network_connect(
target: ConnectTarget, address: String,
username: String, username: String,
event_rx: &mut UnboundedReceiver<Command>, event_rx: &mut UnboundedReceiver<Command>,
proxy_overrides: &ProxyOverrides, proxy_overrides: &ProxyOverrides,
+2 -5
View File
@@ -1,9 +1,6 @@
/// Stub implementation of the platform interface, so that we can /// Stub implementation of the platform interface, so that we can
/// `cargo check` without any --feature flags. /// `cargo check` without any --feature flags.
use crate::{ use crate::{app::SharedState, effects::AudioProcessor};
app::{ConnectTarget, SharedState},
effects::AudioProcessor,
};
use color_eyre::eyre::Error; use color_eyre::eyre::Error;
use futures_channel::mpsc::UnboundedReceiver; use futures_channel::mpsc::UnboundedReceiver;
use mumble_web2_common::{ProxyOverrides, ServerStatus}; use mumble_web2_common::{ProxyOverrides, ServerStatus};
@@ -24,7 +21,7 @@ impl super::PlatformInterface for StubPlatform {
} }
fn network_connect( fn network_connect(
_target: ConnectTarget, _address: String,
_username: String, _username: String,
_event_rx: &mut UnboundedReceiver<crate::app::Command>, _event_rx: &mut UnboundedReceiver<crate::app::Command>,
_overrides: &ProxyOverrides, _overrides: &ProxyOverrides,
+3 -9
View File
@@ -1,4 +1,4 @@
use crate::app::{Command, ConnectTarget, SharedState}; use crate::app::{Command, SharedState};
use crate::effects::{AudioProcessor, AudioProcessorSender, TransmitState}; use crate::effects::{AudioProcessor, AudioProcessorSender, TransmitState};
use color_eyre::eyre::{bail, eyre, Error}; use color_eyre::eyre::{bail, eyre, Error};
use crossbeam::atomic::AtomicCell; use crossbeam::atomic::AtomicCell;
@@ -108,19 +108,13 @@ impl super::PlatformInterface for WebPlatform {
} }
async fn network_connect( async fn network_connect(
target: ConnectTarget, address: String,
username: String, username: String,
event_rx: &mut UnboundedReceiver<Command>, event_rx: &mut UnboundedReceiver<Command>,
overrides: &ProxyOverrides, overrides: &ProxyOverrides,
state: SharedState, state: SharedState,
) -> Result<(), Error> { ) -> Result<(), Error> {
let url = match target { network_connect(address, username, event_rx, overrides, state).await
ConnectTarget::Proxy(url) => url,
ConnectTarget::Direct { .. } => {
bail!("web platform requires a proxy URL, not a direct host:port")
}
};
network_connect(url, username, event_rx, overrides, state).await
} }
async fn get_status( async fn get_status(
-2
View File
@@ -9,5 +9,3 @@ pub use imp::*;
pub use mainloop::*; pub use mainloop::*;
pub use mime_guess; pub use mime_guess;
pub use reqwest; pub use reqwest;
pub const VERSION: Option<&str> = option_env!("MUMBLE_WEB2_VERSION");
+2 -2
View File
@@ -39,7 +39,7 @@ use crate::imp::{
pub async fn network_entrypoint(mut event_rx: UnboundedReceiver<Command>, state: SharedState) { pub async fn network_entrypoint(mut event_rx: UnboundedReceiver<Command>, state: SharedState) {
loop { loop {
let Some(Command::Connect { let Some(Command::Connect {
target, address,
username, username,
config, config,
}) = event_rx.next().await }) = event_rx.next().await
@@ -50,7 +50,7 @@ pub async fn network_entrypoint(mut event_rx: UnboundedReceiver<Command>, state:
*state.server.write_unchecked() = Default::default(); *state.server.write_unchecked() = Default::default();
*state.status.write_unchecked() = ConnectionState::Connecting; *state.status.write_unchecked() = ConnectionState::Connecting;
if let Err(error) = if let Err(error) =
Platform::network_connect(target, username, &mut event_rx, &config, state.clone()) Platform::network_connect(address, username, &mut event_rx, &config, state.clone())
.await .await
{ {
error!("could not connect {:?}", error); error!("could not connect {:?}", error);
+4 -3
View File
@@ -35,11 +35,12 @@ pub struct ServerEntry {
#[cfg(feature = "networking")] #[cfg(feature = "networking")]
pub async fn ping_server(address: &str, port: u16) -> color_eyre::Result<ServerStatus> { pub async fn ping_server(address: &str, port: u16) -> color_eyre::Result<ServerStatus> {
use color_eyre::eyre::{bail, eyre}; use color_eyre::eyre::{bail, eyre};
use std::net::ToSocketAddrs;
use std::time::Duration; use std::time::Duration;
use tokio::net::{lookup_host, UdpSocket}; use tokio::net::UdpSocket;
let dest = lookup_host(format!("{}:{}", address, port)) let dest = format!("{}:{}", address, port)
.await? .to_socket_addrs()?
.next() .next()
.ok_or_else(|| eyre!("could not resolve address"))?; .ok_or_else(|| eyre!("could not resolve address"))?;
-17
View File
@@ -643,23 +643,6 @@ a:visited {
box-shadow: 0 0 0 1px rgba(255, 255, 255, 0.25); box-shadow: 0 0 0 1px rgba(255, 255, 255, 0.25);
} }
.modal-field input:user-invalid,
.modal-field--strict input:invalid {
border-color: rgba(255, 90, 90, 0.85);
box-shadow: 0 0 0 1px rgba(255, 90, 90, 0.45);
}
.modal-field__error {
display: none;
font-size: 0.75rem;
color: #ff8888;
}
.modal-field:has(input:user-invalid) .modal-field__error,
.modal-field--strict:has(input:invalid) .modal-field__error {
display: block;
}
/* Actions row */ /* Actions row */
.modal-actions { .modal-actions {
+183 -336
View File
@@ -3,28 +3,13 @@
use dioxus::prelude::*; use dioxus::prelude::*;
use mumble_web2_client::{ use mumble_web2_client::{
network_entrypoint, reqwest, AudioSettings, ChannelId, Command, ConfigSystem, network_entrypoint, reqwest, AudioSettings, ChannelId, Command, ConfigSystem,
ConfigSystemInterface as _, ConnectTarget, ConnectionState, Platform, PlatformInterface as _, ConfigSystemInterface as _, ConnectionState, Platform, PlatformInterface as _, SharedState,
SharedState, State, UserId, UserState, VERSION, State, UserId, UserState,
}; };
use mumble_web2_common::{ProxyOverrides, ServerEntry}; use mumble_web2_common::{ProxyOverrides, ServerEntry};
use Command::*; use Command::*;
use ConnectionState::*; use ConnectionState::*;
const ADDRESS_PATTERN: &str = "[A-Za-z0-9.-]+";
fn address_is_valid(addr: &str) -> bool {
!addr.is_empty() && !addr.contains(':')
}
fn split_host_port(input: &str) -> (String, Option<String>) {
if let Some((host, port)) = input.rsplit_once(':') {
if !port.is_empty() && port.chars().all(|c| c.is_ascii_digit()) {
return (host.to_string(), Some(port.to_string()));
}
}
(input.to_string(), None)
}
#[derive(Clone, Copy, PartialEq, Eq)] #[derive(Clone, Copy, PartialEq, Eq)]
pub enum UserIcon { pub enum UserIcon {
Normal, Normal,
@@ -510,158 +495,6 @@ pub fn ServerView(overrides: Resource<ProxyOverrides>) -> Element {
) )
} }
#[component]
fn ServerCard(
idx: usize,
server: ServerEntry,
editing_index: Signal<Option<usize>>,
overrides: Resource<ProxyOverrides>,
) -> Element {
let net: Coroutine<Command> = use_coroutine_handle();
let address = format!("{}:{}", server.address, server.port);
let connect_entry = server.clone();
rsx!(
div {
class: "server-card",
img {
class: "server-card__icon",
src: asset!("assets/earth-14-svgrepo-com.svg"),
alt: "Server icon",
}
div {
class: "server-card__info",
span { class: "server-card__name", "{server.name}" }
span { class: "server-card__address", "{address}" }
}
ServerPingInfo {
address: server.address.clone(),
port: server.port,
}
button {
class: "server-card__action",
onclick: move |_| editing_index.set(Some(idx)),
img {
src: asset!("assets/edit-3-svgrepo-com.svg"),
alt: "Edit",
}
}
button {
class: "server-card__action server-card__action--connect",
onclick: {
let entry = connect_entry.clone();
move |_| {
net.send(Connect {
target: ConnectTarget::Direct {
host: entry.address.clone(),
port: entry.port,
},
username: entry.username.clone(),
config: overrides.read().clone().unwrap_or_default(),
});
}
},
img {
src: asset!("assets/arrow-right-svgrepo-com.svg"),
alt: "Connect",
}
}
}
)
}
#[component]
fn OverrideLoginView(overrides: Resource<ProxyOverrides>) -> Element {
let user_config = use_context::<ConfigSystem>();
let net: Coroutine<Command> = use_coroutine_handle();
let state = use_context::<SharedState>();
let proxy_url = overrides
.read()
.as_ref()
.and_then(|c| c.proxy_url.clone())
.unwrap_or_default();
let mut username = use_signal(|| {
user_config
.config_get::<String>("username")
.unwrap_or_default()
});
let is_connecting = matches!(&*state.status.read(), Connecting);
rsx!(
div {
class: "server-list-page",
h1 {
"Mumble Web"
match VERSION {
Some(v) => rsx!(div { class: "login_version", "({v})" }),
None => rsx!(),
}
}
div {
class: "server-list",
div {
class: "server-card",
img {
class: "server-card__icon",
src: asset!("assets/earth-14-svgrepo-com.svg"),
alt: "Server icon",
}
div {
class: "server-card__info",
span { class: "server-card__name", "Server" }
span { class: "server-card__address", "{proxy_url}" }
}
}
div {
class: "override-username-row",
input {
class: "override-username-input",
r#type: "text",
placeholder: "Username",
value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()),
}
button {
class: "server-card__action server-card__action--connect",
disabled: is_connecting || username.read().is_empty(),
onclick: {
let proxy_url = proxy_url.clone();
let user_config = user_config.clone();
move |_| {
user_config.config_set("username", &*username.read());
net.send(Connect {
target: ConnectTarget::Proxy(proxy_url.clone()),
username: username.read().clone(),
config: overrides.read().clone().unwrap_or_default(),
});
}
},
img {
src: asset!("assets/arrow-right-svgrepo-com.svg"),
alt: "Connect",
}
}
}
match &*state.status.read() {
Failed(msg) => rsx!(
div {
class: "login_error",
"Failed to connect:"
pre { "{msg}" }
}
),
_ => rsx!(),
}
}
}
)
}
#[component] #[component]
pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element { pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
let user_config = use_context::<ConfigSystem>(); let user_config = use_context::<ConfigSystem>();
@@ -676,6 +509,8 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
let mut show_add_modal = use_signal(|| false); let mut show_add_modal = use_signal(|| false);
let mut editing_index = use_signal(|| None::<usize>); let mut editing_index = use_signal(|| None::<usize>);
let version = option_env!("MUMBLE_WEB2_VERSION");
let is_override_mode = overrides let is_override_mode = overrides
.read() .read()
.as_ref() .as_ref()
@@ -683,7 +518,89 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
// --- Overrides mode: single preset server, username-only input --- // --- Overrides mode: single preset server, username-only input ---
if is_override_mode { if is_override_mode {
return rsx!(OverrideLoginView { overrides }); let proxy_url = overrides
.read()
.as_ref()
.and_then(|c| c.proxy_url.clone())
.unwrap_or_default();
let mut username = use_signal(|| {
user_config
.config_get::<String>("username")
.unwrap_or_default()
});
let status = &state.status;
let is_connecting = matches!(&*status.read(), Connecting);
return rsx!(
div {
class: "server-list-page",
h1 {
"Mumble Web"
match version {
Some(v) => rsx!(div { class: "login_version", "({v})" }),
None => rsx!(),
}
}
div {
class: "server-list",
div {
class: "server-card",
img {
class: "server-card__icon",
src: asset!("assets/earth-14-svgrepo-com.svg"),
alt: "Server icon",
}
div {
class: "server-card__info",
span { class: "server-card__name", "Server" }
span { class: "server-card__address", "{proxy_url}" }
}
}
div {
class: "override-username-row",
input {
class: "override-username-input",
r#type: "text",
placeholder: "Username",
value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()),
}
button {
class: "server-card__action server-card__action--connect",
disabled: is_connecting || username.read().is_empty(),
onclick: {
let proxy_url = proxy_url.clone();
let user_config = user_config.clone();
move |_| {
user_config.config_set("username", &*username.read());
net.send(Connect {
address: proxy_url.clone(),
username: username.read().clone(),
config: overrides.read().clone().unwrap_or_default(),
});
}
},
img {
src: asset!("assets/arrow-right-svgrepo-com.svg"),
alt: "Connect",
}
}
}
match &*state.status.read() {
Failed(msg) => rsx!(
div {
class: "login_error",
"Failed to connect:"
pre { "{msg}" }
}
),
_ => rsx!(),
}
}
}
);
} }
// --- Normal mode: editable server list --- // --- Normal mode: editable server list ---
@@ -692,7 +609,7 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
class: "server-list-page", class: "server-list-page",
h1 { h1 {
"Mumble Web" "Mumble Web"
match VERSION { match version {
Some(v) => rsx!(div { class: "login_version", "({v})" }), Some(v) => rsx!(div { class: "login_version", "({v})" }),
None => rsx!(), None => rsx!(),
} }
@@ -700,12 +617,57 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
div { div {
class: "server-list", class: "server-list",
for (idx, server) in servers.read().iter().enumerate() { for (idx, server) in servers.read().iter().enumerate() {
ServerCard { {
key: "{idx}", let address = format!("{}:{}", server.address, server.port);
idx, let connect_entry = server.clone();
server: server.clone(), rsx!(
editing_index, div {
overrides, key: "{idx}",
class: "server-card",
img {
class: "server-card__icon",
src: asset!("assets/earth-14-svgrepo-com.svg"),
alt: "Server icon",
}
div {
class: "server-card__info",
span { class: "server-card__name", "{server.name}" }
span { class: "server-card__address", "{address}" }
}
ServerPingInfo {
address: server.address.clone(),
port: server.port,
}
button {
class: "server-card__action",
onclick: move |_| editing_index.set(Some(idx)),
img {
src: asset!("assets/edit-3-svgrepo-com.svg"),
alt: "Edit",
}
}
button {
class: "server-card__action server-card__action--connect",
onclick: {
let entry = connect_entry.clone();
let user_config = user_config.clone();
move |_| {
user_config.config_set("username", &entry.username);
let addr = format!("{}:{}", entry.address, entry.port);
net.send(Connect {
address: addr,
username: entry.username.clone(),
config: overrides.read().clone().unwrap_or_default(),
});
}
},
img {
src: asset!("assets/arrow-right-svgrepo-com.svg"),
alt: "Connect",
}
}
}
)
} }
} }
} }
@@ -728,59 +690,42 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
"+ Add Server" "+ Add Server"
} }
ServerModals { servers, show_add_modal, editing_index } if *show_add_modal.read() {
}
)
}
#[component]
fn ServerModals(
servers: Signal<Vec<ServerEntry>>,
show_add_modal: Signal<bool>,
editing_index: Signal<Option<usize>>,
) -> Element {
let user_config = use_context::<ConfigSystem>();
rsx!(
if *show_add_modal.read() {
{
let user_config = user_config.clone();
let mut servers = servers;
let mut show_add_modal = show_add_modal;
rsx!(AddServerModal {
on_save: move |entry: ServerEntry| {
servers.write().push(entry);
user_config.config_set("servers", &*servers.read());
show_add_modal.set(false);
},
on_cancel: move |_| show_add_modal.set(false),
})
}
}
if let Some(idx) = *editing_index.read() {
if let Some(entry) = servers.read().get(idx).cloned() {
{ {
let user_config_save = user_config.clone(); let user_config = user_config.clone();
let user_config_del = user_config.clone(); rsx!(AddServerModal {
let mut servers = servers; on_save: move |entry: ServerEntry| {
let mut editing_index = editing_index; servers.write().push(entry);
rsx!(EditServerModal { user_config.config_set("servers", &*servers.read());
entry, show_add_modal.set(false);
on_save: move |updated: ServerEntry| {
servers.write()[idx] = updated;
user_config_save.config_set("servers", &*servers.read());
editing_index.set(None);
}, },
on_delete: move |_| { on_cancel: move |_| show_add_modal.set(false),
servers.write().remove(idx);
user_config_del.config_set("servers", &*servers.read());
editing_index.set(None);
},
on_cancel: move |_| editing_index.set(None),
}) })
} }
} }
if let Some(idx) = *editing_index.read() {
if let Some(entry) = servers.read().get(idx).cloned() {
{
let user_config_save = user_config.clone();
let user_config_del = user_config.clone();
rsx!(EditServerModal {
entry,
on_save: move |updated: ServerEntry| {
servers.write()[idx] = updated;
user_config_save.config_set("servers", &*servers.read());
editing_index.set(None);
},
on_delete: move |_| {
servers.write().remove(idx);
user_config_del.config_set("servers", &*servers.read());
editing_index.set(None);
},
on_cancel: move |_| editing_index.set(None),
})
}
}
}
} }
) )
} }
@@ -839,21 +784,9 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
.unwrap_or_default() .unwrap_or_default()
}); });
let mut password = use_signal(|| String::new()); let mut password = use_signal(|| String::new());
let mut address_paste_pending = use_signal(|| false);
let mut submit_attempted = use_signal(|| false);
let do_save = move |_| { let do_save = move |_| {
let Ok(port_num) = port.read().parse::<u16>() else { let port_num: u16 = port.read().parse().unwrap_or(64738);
submit_attempted.set(true);
return;
};
if name.read().is_empty()
|| !address_is_valid(&address.read())
|| username.read().is_empty()
{
submit_attempted.set(true);
return;
}
on_save.call(ServerEntry { on_save.call(ServerEntry {
name: name.read().clone(), name: name.read().clone(),
address: address.read().clone(), address: address.read().clone(),
@@ -867,12 +800,6 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
}); });
}; };
let field_class = if submit_attempted() {
"modal-field modal-field--strict"
} else {
"modal-field"
};
rsx! { rsx! {
div { div {
class: "modal-backdrop", class: "modal-backdrop",
@@ -885,83 +812,43 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
class: "modal", class: "modal",
h2 { "Add Server" } h2 { "Add Server" }
div { div {
class: "{field_class}", class: "modal-field",
label { "Name" } label { "Name" }
input { input {
r#type: "text", r#type: "text",
placeholder: "My Mumble Server", placeholder: "My Mumble Server",
value: "{name.read()}", value: "{name.read()}",
oninput: move |evt| name.set(evt.value().clone()), oninput: move |evt| name.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a name for this server."
} }
} }
div { div {
class: "{field_class}", class: "modal-field",
label { "Address" } label { "Address" }
input { input {
r#type: "text", r#type: "text",
placeholder: "mumble.example.com", placeholder: "mumble.example.com",
pattern: ADDRESS_PATTERN,
value: "{address.read()}", value: "{address.read()}",
onpaste: move |_| address_paste_pending.set(true), oninput: move |evt| address.set(evt.value().clone()),
oninput: move |evt| {
if address_paste_pending() {
address_paste_pending.set(false);
let (host, maybe_port) = split_host_port(&evt.value());
address.set(host);
if let Some(p) = maybe_port {
port.set(p);
}
} else {
address.set(evt.value());
}
},
onblur: move |_| {
let (host, maybe_port) = split_host_port(&address.read());
if let Some(p) = maybe_port {
address.set(host);
port.set(p);
}
},
required: true,
}
div {
class: "modal-field__error",
"Enter a hostname or IP address only — do not include a port."
} }
} }
div { div {
class: "{field_class}", class: "modal-field",
label { "Port" } label { "Port" }
input { input {
r#type: "number", r#type: "number",
placeholder: "64738", placeholder: "64738",
value: "{port.read()}", value: "{port.read()}",
oninput: move |evt| port.set(evt.value().clone()), oninput: move |evt| port.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a port number."
} }
} }
div { div {
class: "{field_class}", class: "modal-field",
label { "Username" } label { "Username" }
input { input {
r#type: "text", r#type: "text",
placeholder: "Nickname", placeholder: "Nickname",
value: "{username.read()}", value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()), oninput: move |evt| username.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a username."
} }
} }
div { div {
@@ -983,6 +870,7 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
} }
button { button {
class: "modal-btn modal-btn--primary", class: "modal-btn modal-btn--primary",
disabled: address.read().is_empty() || username.read().is_empty(),
onclick: do_save, onclick: do_save,
"Save" "Save"
} }
@@ -1004,7 +892,6 @@ fn EditServerModal(
let mut port = use_signal(|| entry.port.to_string()); let mut port = use_signal(|| entry.port.to_string());
let mut username = use_signal(|| entry.username.clone()); let mut username = use_signal(|| entry.username.clone());
let mut password = use_signal(|| entry.password.clone().unwrap_or_default()); let mut password = use_signal(|| entry.password.clone().unwrap_or_default());
let mut address_paste_pending = use_signal(|| false);
let do_save = move |_| { let do_save = move |_| {
let port_num: u16 = port.read().parse().unwrap_or(64738); let port_num: u16 = port.read().parse().unwrap_or(64738);
@@ -1033,83 +920,43 @@ fn EditServerModal(
class: "modal", class: "modal",
h2 { "Edit Server" } h2 { "Edit Server" }
div { div {
class: "modal-field modal-field--strict", class: "modal-field",
label { "Name" } label { "Name" }
input { input {
r#type: "text", r#type: "text",
placeholder: "My Mumble Server", placeholder: "My Mumble Server",
value: "{name.read()}", value: "{name.read()}",
oninput: move |evt| name.set(evt.value().clone()), oninput: move |evt| name.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a name for this server."
} }
} }
div { div {
class: "modal-field modal-field--strict", class: "modal-field",
label { "Address" } label { "Address" }
input { input {
r#type: "text", r#type: "text",
placeholder: "mumble.example.com", placeholder: "mumble.example.com",
pattern: ADDRESS_PATTERN,
value: "{address.read()}", value: "{address.read()}",
onpaste: move |_| address_paste_pending.set(true), oninput: move |evt| address.set(evt.value().clone()),
oninput: move |evt| {
if address_paste_pending() {
address_paste_pending.set(false);
let (host, maybe_port) = split_host_port(&evt.value());
address.set(host);
if let Some(p) = maybe_port {
port.set(p);
}
} else {
address.set(evt.value());
}
},
onblur: move |_| {
let (host, maybe_port) = split_host_port(&address.read());
if let Some(p) = maybe_port {
address.set(host);
port.set(p);
}
},
required: true,
}
div {
class: "modal-field__error",
"Enter a hostname or IP address only — do not include a port."
} }
} }
div { div {
class: "modal-field modal-field--strict", class: "modal-field",
label { "Port" } label { "Port" }
input { input {
r#type: "number", r#type: "number",
placeholder: "64738", placeholder: "64738",
value: "{port.read()}", value: "{port.read()}",
oninput: move |evt| port.set(evt.value().clone()), oninput: move |evt| port.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a port number."
} }
} }
div { div {
class: "modal-field modal-field--strict", class: "modal-field",
label { "Username" } label { "Username" }
input { input {
r#type: "text", r#type: "text",
placeholder: "Nickname", placeholder: "Nickname",
value: "{username.read()}", value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()), oninput: move |evt| username.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a username."
} }
} }
div { div {
@@ -1137,7 +984,7 @@ fn EditServerModal(
} }
button { button {
class: "modal-btn modal-btn--primary", class: "modal-btn modal-btn--primary",
disabled: !address_is_valid(&address.read()) || username.read().is_empty(), disabled: address.read().is_empty() || username.read().is_empty(),
onclick: do_save, onclick: do_save,
"Save" "Save"
} }