gui: stricter validation in add and edit modals
Build Mumble Web 2 / macos_build (push) Successful in 1m12s
Build Mumble Web 2 / linux_build (push) Successful in 1m27s
Build Mumble Web 2 / windows_build (push) Successful in 3m6s
Build Mumble Web 2 / android_build (push) Successful in 4m40s

This commit is contained in:
2026-05-05 05:47:55 +00:00
committed by Sam Sartor
parent 9d6c590315
commit 3e77b943db
2 changed files with 45 additions and 7 deletions
+17
View File
@@ -643,6 +643,23 @@ a:visited {
box-shadow: 0 0 0 1px rgba(255, 255, 255, 0.25); box-shadow: 0 0 0 1px rgba(255, 255, 255, 0.25);
} }
.modal-field input:user-invalid,
.modal-field--strict input:invalid {
border-color: rgba(255, 90, 90, 0.85);
box-shadow: 0 0 0 1px rgba(255, 90, 90, 0.45);
}
.modal-field__error {
display: none;
font-size: 0.75rem;
color: #ff8888;
}
.modal-field:has(input:user-invalid) .modal-field__error,
.modal-field--strict:has(input:invalid) .modal-field__error {
display: block;
}
/* Actions row */ /* Actions row */
.modal-actions { .modal-actions {
+28 -7
View File
@@ -10,6 +10,12 @@ use mumble_web2_common::{ProxyOverrides, ServerEntry};
use Command::*; use Command::*;
use ConnectionState::*; use ConnectionState::*;
const ADDRESS_PATTERN: &str = "[A-Za-z0-9.-]+";
fn address_is_valid(addr: &str) -> bool {
!addr.is_empty() && !addr.contains(':')
}
#[derive(Clone, Copy, PartialEq, Eq)] #[derive(Clone, Copy, PartialEq, Eq)]
pub enum UserIcon { pub enum UserIcon {
Normal, Normal,
@@ -511,10 +517,7 @@ pub fn LoginView(overrides: Resource<ProxyOverrides>) -> Element {
let version = option_env!("MUMBLE_WEB2_VERSION"); let version = option_env!("MUMBLE_WEB2_VERSION");
let is_override_mode = overrides let is_override_mode = overrides.read().as_ref().is_some_and(|c| !c.any_server);
.read()
.as_ref()
.is_some_and(|c| !c.any_server);
// --- Overrides mode: single preset server, username-only input --- // --- Overrides mode: single preset server, username-only input ---
if is_override_mode { if is_override_mode {
@@ -821,6 +824,7 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
placeholder: "My Mumble Server", placeholder: "My Mumble Server",
value: "{name.read()}", value: "{name.read()}",
oninput: move |evt| name.set(evt.value().clone()), oninput: move |evt| name.set(evt.value().clone()),
required: true,
} }
} }
div { div {
@@ -829,8 +833,14 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
input { input {
r#type: "text", r#type: "text",
placeholder: "mumble.example.com", placeholder: "mumble.example.com",
pattern: ADDRESS_PATTERN,
value: "{address.read()}", value: "{address.read()}",
oninput: move |evt| address.set(evt.value().clone()), oninput: move |evt| address.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a hostname or IP address only — do not include a port."
} }
} }
div { div {
@@ -841,6 +851,7 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
placeholder: "64738", placeholder: "64738",
value: "{port.read()}", value: "{port.read()}",
oninput: move |evt| port.set(evt.value().clone()), oninput: move |evt| port.set(evt.value().clone()),
required: true,
} }
} }
div { div {
@@ -851,6 +862,7 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
placeholder: "Nickname", placeholder: "Nickname",
value: "{username.read()}", value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()), oninput: move |evt| username.set(evt.value().clone()),
required: true,
} }
} }
div { div {
@@ -872,7 +884,7 @@ fn AddServerModal(on_save: EventHandler<ServerEntry>, on_cancel: EventHandler<()
} }
button { button {
class: "modal-btn modal-btn--primary", class: "modal-btn modal-btn--primary",
disabled: address.read().is_empty() || username.read().is_empty(), disabled: !address_is_valid(&address.read()) || username.read().is_empty(),
onclick: do_save, onclick: do_save,
"Save" "Save"
} }
@@ -929,16 +941,23 @@ fn EditServerModal(
placeholder: "My Mumble Server", placeholder: "My Mumble Server",
value: "{name.read()}", value: "{name.read()}",
oninput: move |evt| name.set(evt.value().clone()), oninput: move |evt| name.set(evt.value().clone()),
required: true,
} }
} }
div { div {
class: "modal-field", class: "modal-field modal-field--strict",
label { "Address" } label { "Address" }
input { input {
r#type: "text", r#type: "text",
placeholder: "mumble.example.com", placeholder: "mumble.example.com",
pattern: ADDRESS_PATTERN,
value: "{address.read()}", value: "{address.read()}",
oninput: move |evt| address.set(evt.value().clone()), oninput: move |evt| address.set(evt.value().clone()),
required: true,
}
div {
class: "modal-field__error",
"Enter a hostname or IP address only — do not include a port."
} }
} }
div { div {
@@ -949,6 +968,7 @@ fn EditServerModal(
placeholder: "64738", placeholder: "64738",
value: "{port.read()}", value: "{port.read()}",
oninput: move |evt| port.set(evt.value().clone()), oninput: move |evt| port.set(evt.value().clone()),
required: true,
} }
} }
div { div {
@@ -959,6 +979,7 @@ fn EditServerModal(
placeholder: "Nickname", placeholder: "Nickname",
value: "{username.read()}", value: "{username.read()}",
oninput: move |evt| username.set(evt.value().clone()), oninput: move |evt| username.set(evt.value().clone()),
required: true,
} }
} }
div { div {
@@ -986,7 +1007,7 @@ fn EditServerModal(
} }
button { button {
class: "modal-btn modal-btn--primary", class: "modal-btn modal-btn--primary",
disabled: address.read().is_empty() || username.read().is_empty(), disabled: !address_is_valid(&address.read()) || username.read().is_empty(),
onclick: do_save, onclick: do_save,
"Save" "Save"
} }